-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: revamp somatic cnv calling #558
Open
ericblanc20
wants to merge
47
commits into
main
Choose a base branch
from
535-revamp-somatic-cnv-calling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fix path in cnvkit wrappers, better handling of arguments & fix method to obtain input, parameters & output from snakemake
…to the generic models
…g, with updated wrappers
…cnvkit (as much as possible), added to documentation
ericblanc20
changed the title
535 revamp somatic cnv calling
feat: revamp somatic cnv calling
Dec 6, 2024
…, fix path in cnvkit wrappers, better handling of arguments & fix method to obtain input, parameters & output from snakemake
…to the generic models
…g, with updated wrappers
…cnvkit (as much as possible), added to documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNV calling on WES & WGS data for cnvkit tool only (at the moment)
The new
somatic_cnv_calling
step will ultimately replace bothsomatic_wgs_cnv_calling
&somatic_targeted_seq_cnv_calling
.The
panel_of _normals
step had to be adapted to comply with the newcnvkit
implementation.Coding principles
The code is quite involved, due to the complexity of the
cnvkit
pipeline, but I tried to implement some guiding principles:snakemake.input
objects, none as parametersCnvkitWrapper
"--param {args[param]}" if args.get("param", None) is not None else ""
, in the formatting command itself. I figured that I want to keep the command as obvious as possible, near the top of the wrapper code. The formatting is tedious, but always the same in spirit, so I thought it is best ignored the formatting statements are near the bottom of the wrapper code.Overview of the logic
A bit of an overview of the logic might help when reviewing the code.
panel_of_normals
step output & from user-defined files). The 2 others are a flat reference, or a reference build from the paired normal sample only.N
s.